Mark native frames and unavailable methods as subtle (microsoft#409)

mfussenegger · web-flow · commit 57a98e267c94 · 2022-06-08T23:29:02.000+08:00
This causes some clients to display the frames in a different way, e.g
by graying them out.
diff --git a/com.microsoft.java.debug.core/src/main/java/com/microsoft/java/debug/core/adapter/handler/StackTraceRequestHandler.java b/com.microsoft.java.debug.core/src/main/java/com/microsoft/java/debug/core/adapter/handler/StackTraceRequestHandler.java
@@ -95,7 +95,9 @@ private Types.StackFrame convertDebuggerStackFrameToClient(StackFrame stackFrame
         String methodName = formatMethodName(method, true, true);
         int lineNumber = AdapterUtils.convertLineNumber(location.lineNumber(), context.isDebuggerLinesStartAt1(), context.isClientLinesStartAt1());
         // Line number returns -1 if the information is not available; specifically, always returns -1 for native methods.
+        String presentationHint = null;
         if (lineNumber < 0) {
+            presentationHint = "subtle";
             if (method.isNative()) {
                 // For native method, display a tip text "native method" in the Call Stack View.
                 methodName += "[native method]";
@@ -105,7 +107,7 @@ private Types.StackFrame convertDebuggerStackFrameToClient(StackFrame stackFrame
                 clientSource = null;
             }
         }
-        return new Types.StackFrame(frameId, methodName, clientSource, lineNumber, context.isClientColumnsStartAt1() ? 1 : 0);
+        return new Types.StackFrame(frameId, methodName, clientSource, lineNumber, context.isClientColumnsStartAt1() ? 1 : 0, presentationHint);
     }
 
     private Types.Source convertDebuggerSourceToClient(Location location, IDebugAdapterContext context) throws URISyntaxException {
diff --git a/com.microsoft.java.debug.core/src/main/java/com/microsoft/java/debug/core/protocol/Types.java b/com.microsoft.java.debug.core/src/main/java/com/microsoft/java/debug/core/protocol/Types.java
@@ -43,6 +43,8 @@ public static class StackFrame {
         public int line;
         public int column;
         public String name;
+        public String presentationHint;
+
 
         /**
          * Constructs a StackFrame with the given information.
@@ -57,13 +59,17 @@ public static class StackFrame {
          *          line number of the stack frame
          * @param col
          *          column number of the stack frame
+         * @param presentationHint
+         *          An optional hint for how to present this frame in the UI.
+         *          Values: 'normal', 'label', 'subtle'
          */
-        public StackFrame(int id, String name, Source src, int ln, int col) {
+        public StackFrame(int id, String name, Source src, int ln, int col, String presentationHint) {
             this.id = id;
             this.name = name;
             this.source = src;
             this.line = ln;
             this.column = col;
+            this.presentationHint = presentationHint;
         }
     }
 

Original file line number	Diff line number	Diff line change
`@@ -95,7 +95,9 @@ private Types.StackFrame convertDebuggerStackFrameToClient(StackFrame stackFrame`
`95`	`95`	`String methodName = formatMethodName(method, true, true);`
`96`	`96`	`int lineNumber = AdapterUtils.convertLineNumber(location.lineNumber(), context.isDebuggerLinesStartAt1(), context.isClientLinesStartAt1());`
`97`	`97`	`// Line number returns -1 if the information is not available; specifically, always returns -1 for native methods.`
	`98`	`+ String presentationHint = null;`
`98`	`99`	`if (lineNumber < 0) {`
	`100`	`+ presentationHint = "subtle";`
`99`	`101`	`if (method.isNative()) {`
`100`	`102`	`// For native method, display a tip text "native method" in the Call Stack View.`
`101`	`103`	`methodName += "[native method]";`
`@@ -105,7 +107,7 @@ private Types.StackFrame convertDebuggerStackFrameToClient(StackFrame stackFrame`
`105`	`107`	`clientSource = null;`
`106`	`108`	`}`
`107`	`109`	`}`
`108`		`- return new Types.StackFrame(frameId, methodName, clientSource, lineNumber, context.isClientColumnsStartAt1() ? 1 : 0);`
	`110`	`+ return new Types.StackFrame(frameId, methodName, clientSource, lineNumber, context.isClientColumnsStartAt1() ? 1 : 0, presentationHint);`
`109`	`111`	`}`
`110`	`112`
`111`	`113`	`private Types.Source convertDebuggerSourceToClient(Location location, IDebugAdapterContext context) throws URISyntaxException {`