Skip to content

Strongly type timestamps #31891

@rarkins

Description

@rarkins

Describe the proposed change(s).

Similar to what was done for LongCommitSha, we should add a strongly typed Timestamp type, which is a validated Timestamp. We should also consistently use luxon DateTime capabilities throughout if we're not already.

export type Timestamp = string & { __timestamp: never };

Our datasource logic should be updated to only return releaseTimestamp if it's of type Timestamp. Individual datasource implementations could possibly return invalid strings, but they should be filtered before being returned to the worker layer.

Metadata

Metadata

Assignees

Labels

priority-3-mediumDefault priority, "should be done" but isn't prioritised ahead of others

Type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions