Skip to content

Commit b511473

Browse files
SwiftworkSwiftwork
authored
fix: make stop propagated event listeners passive (#458)
1 parent 820cdcc commit b511473

File tree

8 files changed

+14
-38
lines changed

8 files changed

+14
-38
lines changed

‎packages/browser-sdk/example/feedback/feedback.html‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
<head>
44
<meta charset="UTF-8" />
55
<title>Bucket feedback collection</title>
6-
<script src="https://cdn.jsdelivr.net/npm/@bucketco/browser-sdk@1"></script>
6+
<script src="https://cdn.jsdelivr.net/npm/@bucketco/browser-sdk@latest"></script>
77
<style>
88
fieldset label {
99
display: flex;

‎packages/browser-sdk/package.json‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "@bucketco/browser-sdk",
3-
"version": "3.3.2",
3+
"version": "3.3.3",
44
"packageManager": "[email protected]",
55
"license": "MIT",
66
"repository": {

‎packages/browser-sdk/src/feedback/ui/index.ts‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ function attachDialogContainer() {
2626
document.body.appendChild(container);
2727

2828
for (const event of propagatedEvents) {
29-
container.addEventListener(event, stopPropagation);
29+
container.addEventListener(event, stopPropagation, { passive: true });
3030
}
3131
}
3232

‎packages/browser-sdk/src/ui/utils.ts‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ export function attachContainer(containerId: string) {
1616
document.body.appendChild(container);
1717

1818
for (const event of propagatedEvents) {
19-
container.addEventListener(event, stopPropagation);
19+
container.addEventListener(event, stopPropagation, { passive: true });
2020
}
2121
}
2222

‎packages/openfeature-browser-provider/package.json‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "@bucketco/openfeature-browser-provider",
3-
"version": "0.6.1",
3+
"version": "0.6.2",
44
"packageManager": "[email protected]",
55
"license": "MIT",
66
"repository": {
@@ -35,7 +35,7 @@
3535
}
3636
},
3737
"dependencies": {
38-
"@bucketco/browser-sdk": "3.3.1"
38+
"@bucketco/browser-sdk": "3.3.3"
3939
},
4040
"devDependencies": {
4141
"@bucketco/eslint-config": "0.0.2",

‎packages/react-sdk/package.json‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "@bucketco/react-sdk",
3-
"version": "3.3.1",
3+
"version": "3.3.2",
44
"license": "MIT",
55
"repository": {
66
"type": "git",
@@ -34,7 +34,7 @@
3434
}
3535
},
3636
"dependencies": {
37-
"@bucketco/browser-sdk": "3.3.1",
37+
"@bucketco/browser-sdk": "3.3.3",
3838
"canonical-json": "^0.0.4",
3939
"rollup": "^4.2.0"
4040
},

‎packages/vue-sdk/package.json‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "@bucketco/vue-sdk",
3-
"version": "0.2.0",
3+
"version": "0.2.1",
44
"license": "MIT",
55
"repository": {
66
"type": "git",
@@ -34,7 +34,7 @@
3434
}
3535
},
3636
"dependencies": {
37-
"@bucketco/browser-sdk": "3.2.0",
37+
"@bucketco/browser-sdk": "3.3.3",
3838
"canonical-json": "^0.2.0"
3939
},
4040
"peerDependencies": {

‎yarn.lock‎

Lines changed: 4 additions & 28 deletions
Original file line numberDiff line numberDiff line change
@@ -671,31 +671,7 @@ __metadata:
671671
languageName: node
672672
linkType: hard
673673

674-
"@bucketco/browser-sdk@npm:3.2.0":
675-
version: 3.2.0
676-
resolution: "@bucketco/browser-sdk@npm:3.2.0"
677-
dependencies:
678-
"@floating-ui/dom": "npm:^1.6.8"
679-
canonical-json: "npm:^0.0.4"
680-
js-cookie: "npm:^3.0.5"
681-
preact: "npm:^10.22.1"
682-
checksum: 10c0/4663b213f24a1ba7f2878751606cd32752c477ca192fda5a264c6a27d4c6a2db9e4f3a5422bf45bb8ba6c24c2b5249def19f425243d3d754fde0d92231f35562
683-
languageName: node
684-
linkType: hard
685-
686-
"@bucketco/browser-sdk@npm:3.3.1":
687-
version: 3.3.1
688-
resolution: "@bucketco/browser-sdk@npm:3.3.1"
689-
dependencies:
690-
"@floating-ui/dom": "npm:^1.6.8"
691-
canonical-json: "npm:^0.0.4"
692-
js-cookie: "npm:^3.0.5"
693-
preact: "npm:^10.22.1"
694-
checksum: 10c0/30bd1fa0f084c7eee0a22f917bfe488667243013711787bc36c9befa0d3aa27a4aed6f0576416a098b3d3d64ff1cf873587022d4d9c07198e11d4f81f31380de
695-
languageName: node
696-
linkType: hard
697-
698-
"@bucketco/browser-sdk@workspace:packages/browser-sdk":
674+
"@bucketco/browser-sdk@npm:3.3.3, @bucketco/browser-sdk@workspace:packages/browser-sdk":
699675
version: 0.0.0-use.local
700676
resolution: "@bucketco/browser-sdk@workspace:packages/browser-sdk"
701677
dependencies:
@@ -824,7 +800,7 @@ __metadata:
824800
version: 0.0.0-use.local
825801
resolution: "@bucketco/openfeature-browser-provider@workspace:packages/openfeature-browser-provider"
826802
dependencies:
827-
"@bucketco/browser-sdk": "npm:3.3.1"
803+
"@bucketco/browser-sdk": "npm:3.3.3"
828804
"@bucketco/eslint-config": "npm:0.0.2"
829805
"@bucketco/tsconfig": "npm:0.0.2"
830806
"@openfeature/core": "npm:1.5.0"
@@ -870,7 +846,7 @@ __metadata:
870846
version: 0.0.0-use.local
871847
resolution: "@bucketco/react-sdk@workspace:packages/react-sdk"
872848
dependencies:
873-
"@bucketco/browser-sdk": "npm:3.3.1"
849+
"@bucketco/browser-sdk": "npm:3.3.3"
874850
"@bucketco/eslint-config": "workspace:^"
875851
"@bucketco/tsconfig": "workspace:^"
876852
"@testing-library/react": "npm:^15.0.7"
@@ -911,7 +887,7 @@ __metadata:
911887
version: 0.0.0-use.local
912888
resolution: "@bucketco/vue-sdk@workspace:packages/vue-sdk"
913889
dependencies:
914-
"@bucketco/browser-sdk": "npm:3.2.0"
890+
"@bucketco/browser-sdk": "npm:3.3.3"
915891
"@bucketco/eslint-config": "workspace:^"
916892
"@bucketco/tsconfig": "workspace:^"
917893
"@types/jsdom": "npm:^21.1.6"

0 commit comments

Comments
 (0)