fix(node-sdk): ensure timers don't keep process alive (#303)

roncohen · roncohen · commit 579eb1c2d848 · 2025-02-04T11:34:57.000+01:00
Unable to write a test for this, but tested manually.
diff --git a/packages/node-sdk/package.json b/packages/node-sdk/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@bucketco/node-sdk",
-  "version": "1.5.0",
+  "version": "1.5.1",
   "license": "MIT",
   "repository": {
     "type": "git",
diff --git a/packages/node-sdk/src/batch-buffer.ts b/packages/node-sdk/src/batch-buffer.ts
@@ -54,7 +54,7 @@ export default class BatchBuffer<T> {
     if (this.buffer.length >= this.maxSize) {
       await this.flush();
     } else if (!this.timer) {
-      this.timer = setTimeout(() => this.flush(), this.intervalMs);
+      this.timer = setTimeout(() => this.flush(), this.intervalMs).unref();
     }
   }
 
diff --git a/packages/node-sdk/src/cache.ts b/packages/node-sdk/src/cache.ts
@@ -43,7 +43,7 @@ export default function cache<T>(
       logger?.error("failed to update cached value", e);
     } finally {
       refreshPromise = undefined;
-      timeoutId = setTimeout(update, ttl);
+      timeoutId = setTimeout(update, ttl).unref();
     }
   };
 
diff --git a/packages/node-sdk/src/rate-limiter.ts b/packages/node-sdk/src/rate-limiter.ts
@@ -43,7 +43,7 @@ export function newRateLimiter(windowSizeMs: number) {
 
   function isAllowed(key: string): boolean {
     clearIntervalId =
-      clearIntervalId || setInterval(() => clear(false), windowSizeMs);
+      clearIntervalId || setInterval(() => clear(false), windowSizeMs).unref();
 
     const now = Date.now();
 

Original file line number	Diff line number	Diff line change
`@@ -54,7 +54,7 @@ export default class BatchBuffer<T> {`
`54`	`54`	`if (this.buffer.length >= this.maxSize) {`
`55`	`55`	`await this.flush();`
`56`	`56`	`} else if (!this.timer) {`
`57`		`- this.timer = setTimeout(() => this.flush(), this.intervalMs);`
	`57`	`+ this.timer = setTimeout(() => this.flush(), this.intervalMs).unref();`
`58`	`58`	`}`
`59`	`59`	`}`
`60`	`60`
Original file line number	Diff line number	Diff line change
`@@ -43,7 +43,7 @@ export default function cache<T>(`
`43`	`43`	`logger?.error("failed to update cached value", e);`
`44`	`44`	`} finally {`
`45`	`45`	`refreshPromise = undefined;`
`46`		`- timeoutId = setTimeout(update, ttl);`
	`46`	`+ timeoutId = setTimeout(update, ttl).unref();`
`47`	`47`	`}`
`48`	`48`	`};`
`49`	`49`