fix(rules): proper migration of let (#11)

* fix(rules): proper migration of let Fix #8 * refactor: reuse PIPEABLE_OPERATOR_MAPPING
ReactiveX · Apr 18, 2018 · c44252a · c44252a
1 parent 7d92979
commit c44252a
Showing 1 changed file with 10 additions and 3 deletions.
diff --git a/src/migrateToPipeableOperatorsRule.ts b/src/migrateToPipeableOperatorsRule.ts
@@ -323,8 +323,13 @@ function replaceWithPipeableOperators(
   const immediateParentText = immediateParent.getText();
   const identifierStart = immediateParentText.lastIndexOf('.');
   const identifierText = immediateParentText.slice(identifierStart + 1);
-  const pipeableOperator = PIPEABLE_OPERATOR_MAPPING[identifierText] || identifierText;
-  operatorsToImport.add(pipeableOperator);
+  let pipeableOperator = PIPEABLE_OPERATOR_MAPPING[identifierText];
+  if (pipeableOperator === undefined) {
+    pipeableOperator = identifierText;
+  }
+  if (identifierText !== 'let') {
+    operatorsToImport.add(pipeableOperator);
+  }
   // Generates a replacement that would replace .map with map using absolute
   // position of the text to be replaced.
   const operatorReplacement = Lint.Replacement.replaceFromTo(
@@ -454,13 +459,15 @@ const RXJS_OPERATORS = new Set([
   'flatMap',
   'flatMapTo',
   'finally',
-  'switch'
+  'switch',
+  'let'
 ]);
 /**
  * Represents the mapping for pipeable version of some operators whose name has
  * changed due to conflict with JavaScript keyword restrictions.
  */
 const PIPEABLE_OPERATOR_MAPPING: { [key: string]: string } = {
+  let: '',
   do: 'tap',
   catch: 'catchError',
   flatMap: 'mergeMap',