Handle NotImplementedError raised by acl_win #1077
Conversation
|
@ericzolf If you could tkae a look at this one. I did not write unit test as I dont see any specific test for acl_win... |
ericzolf
changed the title
|
I made this PR a draft and removed the WIP prefix, you old GitLab afficionado! 😏 More seriously:
|
|
@ericzolf The git diff looks a bit weird, but honestly, I didn't change much. I just moved most of the code interacting with the DACL into a try...except block and added a new exception type to catch: NotImplementedError. This is all to handle an exception raised by acl.GetAce() when it encounters an unsupported ACE type: |
|
My comment was definitely more about my foggy brain that about your change. |
Signed-off-by: Patrik Dufresne <[email protected]>
ericzolf
force-pushed
the
patrik-fix-acl-win-not-implemented-error
branch
from
749d06b to
e1c3078
Compare
ericzolf
left a comment
ericzolf
left a comment
There was a problem hiding this comment.
I allowed myself to rebase your branch to make the comparison easier locally.
The code itself looks all good to me. Two little things:
- change the commit message to add a FIX explaining the change
- would you mind creating a new test file for win_acl and adding a test (or two)?
|
Out of curiosity, why did you close this PR? |
|
I might have delete the branch my mistake. |
Changes done and why
Change error handling arround acl_win.py to catch
NotImplementedErrorthat get raised byacl.GetAce()when the ACL type is not supported.This issue was repported by a Minarca User.
https://gitlab.com/ikus-soft/minarca/-/issues/324
Self-Checklist