-
-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Split script into logically seperated multiple files #34
Comments
Thank you for the suggestion. I agree that sometimes dividing into parts makes things clear, On the other hand, I don't plan to split files for now, |
Understandable about users that just use the script. However I imagine that most people would run the script from the cloned repo, so they can update it easier and track any changes. (If they have ahk installed, they are probably developers who write other scripts too, right?) Would this be solved if the exe was kept up to date? (ie through ci)? It seems to me that the script is never going to be super portable because you need to have a portable ahk install anyway, meaning the additional complexity of this being multiple scripts instead of one is relatively smaller. |
Would you consider this some more now that the exe is being kept up to date? (Which solves the portability issue, to a large extent?) |
Yes. |
I concur. Feel free to check out my fork to see how I did it, and I believe one of the other contributors split it a different way. For example, mappings should be separate from settings code. Possibly separate out code for the |
ok, I'll employ the policy for development. |
Can I do this and open a PR? Or are you happy to? (I really want this done, especially after the work I just did) |
Closed as #40 was closed. |
Would you consider accepting a PR that refactors out things like UI and settings into different scripts? Folds are ok but it is still unruly trying to jump between different parts of the script or find something you need to check or change, which leads to bugs and forgotten implementations.
Having multiple files
#include
d makes things much clearer to read the project.For an idea of how this might work, see my fork.
The text was updated successfully, but these errors were encountered: