Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changing Overloads for GCC 11/12 bugs #992

Merged
merged 2 commits into from
Nov 8, 2022
Merged

Changing Overloads for GCC 11/12 bugs #992

merged 2 commits into from
Nov 8, 2022

Conversation

divyegala
Copy link
Member

@divyegala divyegala requested a review from a team as a code owner November 7, 2022 17:40
@github-actions github-actions bot added the cpp label Nov 7, 2022
@robertmaynard
Copy link
Contributor

I have verified locally that this fixes the compile issues seen in rsvd.cu

cjnolet
cjnolet approved these changes Nov 7, 2022
View reviewed changes
Copy link
Member

@cjnolet cjnolet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM pending CI. Looks like there's a couple minor failures during the docs build.

@divyegala divyegala added bug Something isn't working non-breaking Non-breaking change labels Nov 7, 2022
@cjnolet
Copy link
Member

cjnolet commented Nov 8, 2022

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 3f46a3b into rapidsai:branch-22.12 Nov 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjnolet cjnolet cjnolet approved these changes

Assignees
No one assigned
Labels
bug Something isn't working cpp non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@divyegala @robertmaynard @cjnolet