Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add unittest for linalg::mean_squared_error #961

Merged
merged 1 commit into from
Oct 28, 2022
Merged

Add unittest for linalg::mean_squared_error #961

merged 1 commit into from
Oct 28, 2022

Conversation

benfred
Copy link
Member

@benfred benfred commented Oct 27, 2022

Closes #872

@benfred benfred requested review from a team as code owners October 27, 2022 20:41
@benfred benfred added enhancement New feature or request non-breaking Non-breaking change labels Oct 27, 2022
@cjnolet cjnolet added improvement Improvement / enhancement to an existing function and removed enhancement New feature or request labels Oct 27, 2022
cjnolet
cjnolet approved these changes Oct 28, 2022
View reviewed changes
Copy link
Member

@cjnolet cjnolet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great, @benfred. Thanks!

@cjnolet
Copy link
Member

cjnolet commented Oct 28, 2022

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 7e95567 into rapidsai:branch-22.12 Oct 28, 2022
@benfred benfred deleted the mse_test branch October 28, 2022 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjnolet cjnolet cjnolet approved these changes

Assignees
No one assigned
Labels
CMake cpp improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
VS/ML/DM Primitives Release Board
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] linalg::mean_squared_error needs gtest
2 participants
@benfred @cjnolet