Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some cleanup of k-means internals #953

Merged
merged 29 commits into from
Oct 28, 2022
Merged

Some cleanup of k-means internals #953

merged 29 commits into from
Oct 28, 2022

Conversation

cjnolet
Copy link
Member

@cjnolet cjnolet commented Oct 25, 2022 •
edited
Loading

This also refactors the update centroids logic into its own function in the detail API. Also exposing update_centroids function for scikit-learn pluggability.

@cjnolet cjnolet added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Oct 25, 2022
@cjnolet cjnolet requested review from a team as code owners October 25, 2022 19:45
@github-actions github-actions bot removed the python label Oct 25, 2022
@cjnolet cjnolet requested a review from a team as a code owner October 25, 2022 21:32
dantegd
dantegd approved these changes Oct 28, 2022
View reviewed changes
Copy link
Member

@dantegd dantegd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very minor comment, looks good

cpp/include/raft/cluster/detail/kmeans_common.cuh Outdated Show resolved Hide resolved
cpp/include/raft/cluster/kmeans.cuh Show resolved Hide resolved
@cjnolet
Copy link
Member Author

cjnolet commented Oct 28, 2022

@gpucibot merge

@rapids-bot rapids-bot bot merged commit d199a9f into rapidsai:branch-22.12 Oct 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@divyegala divyegala divyegala approved these changes

@dantegd dantegd dantegd approved these changes

Assignees
No one assigned
Labels
CMake cpp improvement Improvement / enhancement to an existing function non-breaking Non-breaking change python
Projects
VS/ML/DM Primitives Release Board
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cjnolet @dantegd @divyegala