Removing cub symbol from libraft-distance instantiation. #887
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seunghwak
approved these changes
Oct 4, 2022
BradReesWork
approved these changes
Oct 4, 2022
|
@gpucibot merge |
cjnolet
added a commit
to cjnolet/raft
that referenced
this pull request
Oct 6, 2022
…idsai#887)" This reverts commit 55953f3.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The recent template instantiations for
fusedL2NNincludedcub::KeyValuePairin the symbols. Unfortunately, the cub symbols end up including all of the cuda architectures upon which it is built in the symbol name. For example, if libraft-distance is built for 5 architectures then someone building locally using that libraft-distance package for only their architecture will get an undefined symbol error. The best solution here is to not allow symbols from cub to leak through any publicly exposed APIs (even if those APIs are template instantiations of implementaiton details).I'm also adding a new
raft::KeyValuePairobject which has a conversion constructor so we can still easily make use ofcub::KeyValuePairinside RAFT functions which use our new KVP object.