Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Breaking apart benchmarks into individual binaries #883

Merged
merged 1 commit into from
Oct 4, 2022
Merged

Breaking apart benchmarks into individual binaries #883

merged 1 commit into from
Oct 4, 2022

Conversation

cjnolet
Copy link
Member

@cjnolet cjnolet commented Oct 4, 2022

No description provided.

@cjnolet cjnolet added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Oct 4, 2022
@cjnolet cjnolet requested a review from a team as a code owner October 4, 2022 15:18
divyegala
divyegala approved these changes Oct 4, 2022
View reviewed changes
Copy link
Member

@divyegala divyegala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love this!

@cjnolet
Copy link
Member Author

cjnolet commented Oct 4, 2022

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 844a919 into rapidsai:branch-22.10 Oct 4, 2022
ahendriksen
ahendriksen reviewed Oct 5, 2022
View reviewed changes
BUILD.md
```bash
./build.sh libraft bench
```

To run the benchmarks:
It can take sometime to compile all of the tests. You can build individual tests by providing a semicolon-separated list to the `--limit-tests` option in `build.sh`:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you meant "compile all of the benchmarks"? It would make sense to replace "test" by "benchmark" on this line.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahendriksen ahendriksen ahendriksen left review comments

@divyegala divyegala divyegala approved these changes

Assignees
No one assigned
Labels
CMake cpp improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cjnolet @ahendriksen @divyegala