ivf-pq post integration hotfixes #878
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Three fixes to ivf_pq::search:
1. Type in argument name of select_cluster (n_queries -> queries_batch) which lead to illegal memory access for large batches
2. Removed unnecessary argument `max_batch_size` from the worker function.
3. Replaces <<<bracket-calling>>> of dynamically selected kernels with cudaLaunchKernel invocations.
The former led to the kernels silently being not called at all in some cases for no apparent reason (not reproducible in tests).
achirkin
added
bug
tfeher
approved these changes
Oct 4, 2022
|
@gpucibot merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes to ivf_pq::search:
select_cluster(n_queries -> queries_batch) which led to illegal memory access for large batches.max_batch_sizefrom the worker function.<<<bracket-calling>>>of dynamically selected kernels withcudaLaunchKernelinvocations.The former led to the kernels silently being not called at all in some cases for no apparent reason (not reproducible in tests).
Fixes to ivf_pq::build:
raft/util/device_atomics.cuhpassed unnoticed due to transient dependencies.