[REVIEW] mdspan-ify several raft::random rng functions #857
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mhoemmen
added
feature request
Add overloads taking the output vector as mdspan, of the following raft::random functions: * normal * lognormal * uniform * gumbel * logistic * exponential * rayleigh * laplace
mhoemmen
force-pushed
the
mdspanify-random-rest
branch
from
7ab6045 to
e855198
Compare
mhoemmen
changed the title
cjnolet
approved these changes
Sep 29, 2022
|
@gpucibot merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add overloads taking the output vector as mdspan, of the following
raft::randomfunctions:I plan to finish the remaining
raft::randomfunctions as part of this PR. However, this PR should be ready to merge now.