Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mdspan-ifying raft::spatial #827

Merged
merged 38 commits into from
Oct 1, 2022

Conversation

cjnolet
Copy link
Member

@cjnolet cjnolet commented Sep 14, 2022

No description provided.

@cjnolet cjnolet added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Sep 14, 2022
@cjnolet cjnolet requested a review from a team as a code owner September 14, 2022 18:52
@github-actions github-actions bot added the cpp label Sep 14, 2022
@cjnolet cjnolet requested a review from a team as a code owner September 15, 2022 21:39
@robertmaynard robertmaynard removed the request for review from a team September 21, 2022 14:09
Copy link
Contributor

@mhoemmen mhoemmen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lots of work!!! I made a few suggestions, none of which are required.

cpp/include/raft/spatial/knn/ball_cover.cuh Outdated Show resolved Hide resolved
cpp/include/raft/spatial/knn/ball_cover.cuh Outdated Show resolved Hide resolved
cpp/include/raft/spatial/knn/ball_cover.cuh Outdated Show resolved Hide resolved
cpp/include/raft/spatial/knn/ball_cover_types.hpp Outdated Show resolved Hide resolved
cpp/include/raft/spatial/knn/ivf_flat.cuh Outdated Show resolved Hide resolved
cpp/include/raft/spatial/knn/knn.cuh Outdated Show resolved Hide resolved
cpp/include/raft/spatial/knn/knn.cuh Outdated Show resolved Hide resolved
cpp/include/raft/spatial/knn/knn.cuh Outdated Show resolved Hide resolved
cpp/test/spatial/ann_ivf_flat.cu Outdated Show resolved Hide resolved
cpp/test/spatial/epsilon_neighborhood.cu Show resolved Hide resolved
cpp/include/raft/spatial/knn/ball_cover.cuh Show resolved Hide resolved
cpp/include/raft/spatial/knn/ball_cover.cuh Outdated Show resolved Hide resolved
cpp/include/raft/spatial/knn/ball_cover.cuh Outdated Show resolved Hide resolved
cpp/include/raft/spatial/knn/ivf_flat.cuh Outdated Show resolved Hide resolved
cpp/include/raft/spatial/knn/knn.cuh Outdated Show resolved Hide resolved
cpp/include/raft/spatial/knn/knn.cuh Outdated Show resolved Hide resolved
cpp/test/spatial/ann_ivf_flat.cu Outdated Show resolved Hide resolved
@cjnolet
Copy link
Member Author

cjnolet commented Oct 1, 2022

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 2bd8d04 into rapidsai:branch-22.10 Oct 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cpp improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants