Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement raft::stats API with mdspan #802

Merged
merged 50 commits into from
Oct 7, 2022
Merged

Implement raft::stats API with mdspan #802

merged 50 commits into from
Oct 7, 2022

Conversation

lowener
Copy link
Contributor

@lowener lowener commented Sep 5, 2022

Part of #535.
Implementation of the raft::stats API with mdspan, with the C++ tests
14/22 Files implemented. The remaining files will come in a following PR.

@github-actions github-actions bot added the cpp label Sep 5, 2022
@lowener lowener added feature request New feature or request non-breaking Non-breaking change 2 - In Progress Currenty a work in progress labels Sep 5, 2022
mhoemmen
mhoemmen reviewed Sep 7, 2022
View reviewed changes
cpp/include/raft/stats/accuracy.cuh Outdated Show resolved Hide resolved
cpp/include/raft/stats/accuracy.cuh Outdated Show resolved Hide resolved
cpp/include/raft/stats/accuracy.cuh Show resolved Hide resolved
cpp/include/raft/stats/contingency_matrix.cuh Outdated Show resolved Hide resolved
cpp/include/raft/stats/contingency_matrix.cuh Outdated Show resolved Hide resolved
cpp/include/raft/stats/histogram.cuh Show resolved Hide resolved
cpp/include/raft/stats/histogram.cuh Outdated Show resolved Hide resolved
cpp/include/raft/stats/mean.cuh Show resolved Hide resolved
cpp/test/stats/dispersion.cu Show resolved Hide resolved
cpp/include/raft/stats/minmax.cuh Outdated Show resolved Hide resolved
mhoemmen added a commit to mhoemmen/raft that referenced this pull request Oct 5, 2022
@mhoemmen
Add an mdspan overload of raft::random::normalInt
2e9d2b4 
This touches a test file changed by PR rapidsai#802,
but this commit should not conflict with that PR.
@cjnolet cjnolet requested a review from a team as a code owner October 6, 2022 02:05
@cjnolet
Copy link
Member

cjnolet commented Oct 6, 2022

rerun tests

@cjnolet cjnolet added 5 - Ready to Merge and removed 2 - In Progress Currenty a work in progress labels Oct 6, 2022
@cjnolet cjnolet changed the base branch from branch-22.10 to branch-22.12 October 6, 2022 20:00
@cjnolet
Copy link
Member

cjnolet commented Oct 7, 2022

rerun tests

@github-actions github-actions bot added the CMake label Oct 7, 2022
@cjnolet
Copy link
Member

cjnolet commented Oct 7, 2022

@gpucibot merge

@rapids-bot rapids-bot bot merged commit f56daa6 into rapidsai:branch-22.12 Oct 7, 2022
@lowener lowener deleted the 22.10-stats-api branch October 8, 2022 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@divyegala divyegala divyegala left review comments

@mhoemmen mhoemmen mhoemmen left review comments

@cjnolet cjnolet cjnolet approved these changes

Assignees
No one assigned
Labels
5 - Ready to Merge CMake cpp feature request New feature or request non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lowener @cjnolet @mhoemmen @divyegala