-
Notifications
You must be signed in to change notification settings - Fork 197
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Renaming pyraft
-> raft-dask
#801
Conversation
These change should not be breaking to downstream projects, however, any projects dependent upon |
@cjnolet let me know if you think this PR needs a general review (from a non-raft person) at some point. |
@vyasr sure, if you have some time you are welcome to review this PR. |
"official dask" blessed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR and name change look great to me
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few minor comments to address. You should also update the update-version.sh
script.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@gpucibot merge |
dask-raft
is a more appropriate name. If needed, I will also move the contents ofraft.common
fromdask-raft
over topylibraft
and makepylibraft
a dependency ofdask-raft
. I will do that after seeing who's still using those classes, though.