Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renaming pyraft -> raft-dask #801

Merged
merged 16 commits into from
Sep 9, 2022

Conversation

cjnolet
Copy link
Member

@cjnolet cjnolet commented Sep 2, 2022

dask-raft is a more appropriate name. If needed, I will also move the contents of raft.common from dask-raft over to pylibraft and make pylibraft a dependency of dask-raft. I will do that after seeing who's still using those classes, though.

@cjnolet cjnolet requested review from a team as code owners September 2, 2022 18:08
@cjnolet cjnolet added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Sep 2, 2022
@cjnolet
Copy link
Member Author

cjnolet commented Sep 2, 2022

These change should not be breaking to downstream projects, however, any projects dependent upon pyraft will need to be updated to use dask-raft before the 22.10 release.

@vyasr
Copy link
Contributor

vyasr commented Sep 7, 2022

@cjnolet let me know if you think this PR needs a general review (from a non-raft person) at some point.

@cjnolet
Copy link
Member Author

cjnolet commented Sep 8, 2022

@vyasr sure, if you have some time you are welcome to review this PR.

@cjnolet cjnolet changed the title Renaming pyraft -> dask-raft Renaming pyraft -> raft-dask Sep 8, 2022
Copy link
Member

@dantegd dantegd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR and name change look great to me

ci/gpu/build.sh Outdated Show resolved Hide resolved
Copy link
Contributor

@vyasr vyasr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few minor comments to address. You should also update the update-version.sh script.

python/raft-dask/CMakeLists.txt Outdated Show resolved Hide resolved
python/raft-dask/CMakeLists.txt Outdated Show resolved Hide resolved
python/pylibraft/pyproject.toml Show resolved Hide resolved
ci/cpu/upload.sh Outdated Show resolved Hide resolved
ci/cpu/upload.sh Outdated Show resolved Hide resolved
ci/cpu/upload.sh Outdated Show resolved Hide resolved
ci/cpu/upload.sh Outdated Show resolved Hide resolved
ci/gpu/build.sh Show resolved Hide resolved
python/pylibraft/pylibraft/common/handle.pxd Show resolved Hide resolved
Copy link
Contributor

@vyasr vyasr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cjnolet
Copy link
Member Author

cjnolet commented Sep 8, 2022

@gpucibot merge

@rapids-bot rapids-bot bot merged commit c505410 into rapidsai:branch-22.10 Sep 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CMake gpuCI improvement Improvement / enhancement to an existing function non-breaking Non-breaking change python
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants