Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor follow-up fixes for ivf-flat #796

Merged
merged 1 commit into from
Sep 2, 2022
Merged

Minor follow-up fixes for ivf-flat #796

merged 1 commit into from
Sep 2, 2022

Conversation

achirkin
Copy link
Contributor

@achirkin achirkin commented Sep 1, 2022

Small fixes to ivf-flat and its dependency warp_sort:

  • fix the template parameter for the call of calc_smem_size_for_block_wide (may reduce the use of shared memory);
  • force initialize warp_sort internal value buffers to avoid uninitialized output in case of very small input data size;
  • small readability fixes.

@achirkin achirkin requested a review from a team as a code owner September 1, 2022 12:31
@github-actions github-actions bot added the cpp label Sep 1, 2022
@achirkin achirkin added 3 - Ready for Review improvement Improvement / enhancement to an existing function non-breaking Non-breaking change cpp and removed cpp labels Sep 1, 2022
tfeher
tfeher approved these changes Sep 2, 2022
View reviewed changes
Copy link
Contributor

@tfeher tfeher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Artem for the PR, LGTM.

@cjnolet
Copy link
Member

cjnolet commented Sep 2, 2022

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 8b97c1b into rapidsai:branch-22.10 Sep 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tfeher tfeher tfeher approved these changes

Assignees
No one assigned
Labels
3 - Ready for Review cpp improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@achirkin @cjnolet @tfeher