Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding old kmeans impl back in (as kmeans_deprecated) #761

Merged
merged 3 commits into from
Jul 28, 2022
Merged

Adding old kmeans impl back in (as kmeans_deprecated) #761

merged 3 commits into from
Jul 28, 2022

Conversation

cjnolet
Copy link
Member

@cjnolet cjnolet commented Jul 27, 2022 •
edited
Loading

The new k-means implementation increased the build time significantly, which has a direct impact on our users who are also having to build against it. For now, I'm adding the old kmeans back in (albeit deprecating it) so that we unblock our users.

@cjnolet cjnolet added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Jul 27, 2022
@cjnolet cjnolet marked this pull request as ready for review July 27, 2022 21:07
@cjnolet cjnolet requested review from a team as code owners July 27, 2022 21:07
@cjnolet cjnolet changed the title Adding old kmeans impl back in (as kmeans_2) Adding old kmeans impl back in (as kmeans_deprecated) Jul 27, 2022
@cjnolet
Copy link
Member Author

cjnolet commented Jul 27, 2022

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 20b6ee5 into rapidsai:branch-22.08 Jul 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@divyegala divyegala divyegala approved these changes

Assignees
No one assigned
Labels
CMake cpp improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cjnolet @divyegala