Add warp-aggregated atomic increment #735
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahendriksen
added
improvement
|
Moving this functionality from cuml to raft as discussed in rapidsai/cuml#4803 |
ahendriksen
force-pushed
the
fea-add-warp-aggregated-atomic-increment
branch
from
4a76a73 to
a001020
Compare
ahendriksen
added
3 - Ready for Review
and removed
2 - In Progress
tfeher
requested changes
Jul 12, 2022
Faster atomic counter increment using warp-aggregated atomics. Useful for filtering. Adapted from: https://developer.nvidia.com/blog/cuda-pro-tip-optimized-filtering-warp-aggregated-atomics/
ahendriksen
force-pushed
the
fea-add-warp-aggregated-atomic-increment
branch
from
a001020 to
04ea9a7
Compare
|
I have added a unit test. |
ahendriksen
changed the title
tfeher
approved these changes
Jul 13, 2022
There was a problem hiding this comment.
Thanks @ahendriksen for adding the test! The PR looks good to me.
ahendriksen
changed the title
ahendriksen
changed the title
ahendriksen
changed the title
cjnolet
approved these changes
Jul 14, 2022
There was a problem hiding this comment.
LGTM. Just a tiny question / nitpick in the test. Thanks @ahendriksen!
| out_device.data()); | ||
|
|
||
| // Copy data to host | ||
| RAFT_CUDA_TRY(cudaMemcpy(out_host.data(), |
|
@gpucibot merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement fast atomic counter increment using warp-aggregated atomics. Useful
for filtering.
Adapted from:
https://developer.nvidia.com/blog/cuda-pro-tip-optimized-filtering-warp-aggregated-atomics/