Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Testing conda compilers #705

Merged
merged 41 commits into from
Jun 15, 2022
Merged

Conversation

cjnolet
Copy link
Member

@cjnolet cjnolet commented Jun 6, 2022

No description provided.

@cjnolet cjnolet added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Jun 6, 2022
@cjnolet cjnolet requested a review from a team as a code owner June 6, 2022 22:12
cjnolet and others added 23 commits June 6, 2022 18:15
…#641)

This PR includes the following changes:
- Adds a `libraft-tests` package to the `libraft-split` recipe
  - This is a prerequisite for removing "Project Flash" from our build/CI scripts
   - The `libraft-tests` package was added as an additional output to the `libraft-split` recipe
- Consolidates remaining C++ recipes into `libraft-split` recipe
   - This gets rid of a lot of duplicate code between the recipes and reduces the number of times we have to call conda build in our CI scripts
- Migrate the "from sources" builds done in GPU tests by building packages using conda. This is done for the following reasons:
  - This is required step to improve the Ops CI/CD setup to a more convenient pipeline
  - This is required to start using conda compilers and `mamba` to build RAPIDS packages
  - This prevent us from manually managing and installing the dependencies in GPU job
  - This ensure the packages can be installed (no conda conflict while installing)
  - This ensure the tests are running and working against the package content and not the build results. Currently the Python packages are not tested

Dependency version specs are now specified in `conda/recipes/libraft/conda_build_config.yaml`. The exception here is the version spec used for cudatoolkit since that comes from an environment variable in the CI process.

Authors:
  - Jordan Jacobelli (https://github.com/Ethyling)

Approvers:
  - Corey J. Nolet (https://github.com/cjnolet)
  - AJ Schmidt (https://github.com/ajschmidt8)

URL: rapidsai#641
`CMAKE_ARGS` is a special environment variable in conda-forge's build process, so we need to avoid shadowing it.

Authors:
  - Vyas Ramasubramani (https://github.com/vyasr)

Approvers:
  - Corey J. Nolet (https://github.com/cjnolet)

URL: rapidsai#701
@github-actions github-actions bot added the gpuCI label Jun 7, 2022
@cjnolet
Copy link
Member Author

cjnolet commented Jun 13, 2022

rerun tests

@cjnolet
Copy link
Member Author

cjnolet commented Jun 14, 2022

rerun tests

@cjnolet
Copy link
Member Author

cjnolet commented Jun 15, 2022

rerun tests

Copy link
Contributor

@msadang msadang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cjnolet
Copy link
Member Author

cjnolet commented Jun 15, 2022

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 9b594b8 into rapidsai:branch-22.08 Jun 15, 2022
@jakirkham
Copy link
Member

Thanks Corey! 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gpuCI improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants