Require UCX 1.12.1+ #638
Require UCX 1.12.1+ #638
Conversation
cjnolet
added
improvement
| @@ -0,0 +1,2 @@ | |||
| ucx_version: | |||
| - "1.12.1" | |||
There was a problem hiding this comment.
I think this should be >=1.12.1
There was a problem hiding this comment.
The intent here is to ensure we have a fixed version at build time so that this sets a minimum version at runtime.
There was a problem hiding this comment.
Oh, I thought we wanted to build using the latest version available. What's the difference between doing this and using pin_compatible for the runtime dependency?
There was a problem hiding this comment.
We are using the latest version since 1.12.1 is latest. However we may want more flexibility if a later 1.12.x breaks something and we need to pin an older version in the metapackage. Also we may want to control which version we build against to make it easier to align with other packages that have ucx constraints as well.
FWIW am proposing something similar in conda-forge ( conda-forge/conda-forge-pinning-feedstock#2847 ) though maybe we can wait to see what others think about that and update if needed.
| @@ -42,6 +43,7 @@ requirements: | |||
| - libraft-headers {{ version }} | |||
| - nccl>=2.9.9 | |||
| - rmm {{ minor_version }} | |||
| - ucx >={{ ucx_version }} | |||
There was a problem hiding this comment.
I think we should remove the >= here
There was a problem hiding this comment.
Please see comment above
There was a problem hiding this comment.
That said, we can probably drop this line as the feedstock has run_exports, which covers adding and pinning this.
|
@gpucibot merge |
xref: rapidsai/integration#471