Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix make_device_vector_view #595

Merged
merged 1 commit into from
Mar 28, 2022
Merged

Fix make_device_vector_view #595

merged 1 commit into from
Mar 28, 2022

Conversation

lowener
Copy link
Contributor

@lowener lowener commented Mar 28, 2022

Small typo fix.

@lowener lowener requested a review from a team as a code owner March 28, 2022 16:25
@github-actions github-actions bot added the cpp label Mar 28, 2022
@cjnolet cjnolet added bug Something isn't working non-breaking Non-breaking change labels Mar 28, 2022
cjnolet
cjnolet approved these changes Mar 28, 2022
View reviewed changes
Copy link
Member

@cjnolet cjnolet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cjnolet
Copy link
Member

cjnolet commented Mar 28, 2022

rerun tests

trivialfis
trivialfis approved these changes Mar 28, 2022
View reviewed changes
Copy link
Member

@trivialfis trivialfis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apologies for the bug, LGTM.

@cjnolet
Copy link
Member

cjnolet commented Mar 28, 2022

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 6aa9ac8 into rapidsai:branch-22.04 Mar 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trivialfis trivialfis trivialfis approved these changes

@cjnolet cjnolet cjnolet approved these changes

Assignees
No one assigned
Labels
bug Something isn't working cpp non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lowener @cjnolet @trivialfis