-
Notifications
You must be signed in to change notification settings - Fork 197
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pylibraft for pairwise distances #540
Pylibraft for pairwise distances #540
Conversation
link to it. Using raft::raft only as internal (build) target
overwritten (this allows downstream projects to continue to use it until they update
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving ops-codeowner
file changes
rerun tests |
rerun tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR looks very good to me and after spending some time going over it, I think it is good to go as-is from my side.
rerun tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just had one minor comment, approving
@gpucibot merge |
@gpucibot merge |
…ibcuxx` cmake dependencies (#2132) Note: This PR depends on rapidsai/raft#540 and should work once it is merged. Authors: - Corey J. Nolet (https://github.com/cjnolet) Approvers: - Chuck Hastings (https://github.com/ChuckHastings) - Rick Ratzel (https://github.com/rlratzel) URL: #2132
The goal w/ the initial pylibraft package is to 1) create one end to end API (distances) and 2) show how we would reuse specializations from the existing shared libs in order to expose primitives through Python using minimal dependencies (only rmm, numpy, and scipy, for example).
Closes #546