Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pylibraft for pairwise distances #540

Merged
merged 144 commits into from
Mar 21, 2022

Conversation

cjnolet
Copy link
Member

@cjnolet cjnolet commented Mar 2, 2022

The goal w/ the initial pylibraft package is to 1) create one end to end API (distances) and 2) show how we would reuse specializations from the existing shared libs in order to expose primitives through Python using minimal dependencies (only rmm, numpy, and scipy, for example).

Closes #546

@cjnolet cjnolet added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Mar 2, 2022
@cjnolet cjnolet requested review from a team as code owners March 2, 2022 01:16
@cjnolet cjnolet self-assigned this Mar 7, 2022
Copy link
Member

@ajschmidt8 ajschmidt8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving ops-codeowner file changes

@cjnolet
Copy link
Member Author

cjnolet commented Mar 18, 2022

rerun tests

@cjnolet
Copy link
Member Author

cjnolet commented Mar 18, 2022

rerun tests

README.md Outdated Show resolved Hide resolved
cpp/include/raft/comms/comms.hpp Show resolved Hide resolved
cpp/test/CMakeLists.txt Show resolved Hide resolved
BUILD.md Outdated Show resolved Hide resolved
BUILD.md Outdated Show resolved Hide resolved
BUILD.md Outdated Show resolved Hide resolved
BUILD.md Outdated Show resolved Hide resolved
BUILD.md Show resolved Hide resolved
BUILD.md Outdated Show resolved Hide resolved
python/pylibraft/pylibraft/distance/pairwise_distance.pyx Outdated Show resolved Hide resolved
python/pylibraft/pylibraft/distance/pairwise_distance.pyx Outdated Show resolved Hide resolved
python/pylibraft/pylibraft/test/test_distance.py Outdated Show resolved Hide resolved
python/pylibraft/setup.cfg Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
Copy link
Member

@divyegala divyegala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR looks very good to me and after spending some time going over it, I think it is good to go as-is from my side.

@cjnolet cjnolet mentioned this pull request Mar 21, 2022
@cjnolet
Copy link
Member Author

cjnolet commented Mar 21, 2022

rerun tests

Copy link
Member

@dantegd dantegd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just had one minor comment, approving

cpp/cmake/versions.json Outdated Show resolved Hide resolved
@cjnolet
Copy link
Member Author

cjnolet commented Mar 21, 2022

@gpucibot merge

@cjnolet
Copy link
Member Author

cjnolet commented Mar 21, 2022

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 0d777ea into rapidsai:branch-22.04 Mar 21, 2022
rapids-bot bot pushed a commit to rapidsai/cugraph that referenced this pull request Apr 19, 2022
…ibcuxx` cmake dependencies (#2132)

Note: This PR depends on rapidsai/raft#540 and should work once it is merged.

Authors:
  - Corey J. Nolet (https://github.com/cjnolet)

Approvers:
  - Chuck Hastings (https://github.com/ChuckHastings)
  - Rick Ratzel (https://github.com/rlratzel)

URL: #2132
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CMake cpp gpuCI improvement Improvement / enhancement to an existing function non-breaking Non-breaking change python
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEA] Make UCX / NCCL dependencies optional
5 participants