Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mdspan PoC for distance make_blobs #538

Merged
merged 14 commits into from
Mar 9, 2022
Merged

mdspan PoC for distance make_blobs #538

merged 14 commits into from
Mar 9, 2022

Conversation

cjnolet
Copy link
Member

@cjnolet cjnolet commented Mar 1, 2022

No description provided.

@cjnolet cjnolet added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Mar 1, 2022
@cjnolet cjnolet requested a review from a team as a code owner March 1, 2022 21:42
@github-actions github-actions bot added the cpp label Mar 1, 2022
@cjnolet cjnolet self-assigned this Mar 1, 2022
@cjnolet
Copy link
Member Author

cjnolet commented Mar 3, 2022

rerun tests

dantegd
dantegd requested changes Mar 7, 2022
View reviewed changes
Copy link
Member

@dantegd dantegd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look fantastic, just added comments about additional documentation

README.md Show resolved Hide resolved
README.md Show resolved Hide resolved
README.md Show resolved Hide resolved
@cjnolet
Copy link
Member Author

cjnolet commented Mar 9, 2022

rerun tests

@cjnolet
Copy link
Member Author

cjnolet commented Mar 9, 2022

@gpucibot merge

@rapids-bot rapids-bot bot merged commit c0925f3 into rapidsai:branch-22.04 Mar 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dantegd dantegd dantegd approved these changes

Assignees

@cjnolet cjnolet

Labels
cpp improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cjnolet @dantegd