Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace ccache with sccache #471

Merged
merged 8 commits into from
Feb 3, 2022
Merged

Replace ccache with sccache #471

merged 8 commits into from
Feb 3, 2022

Conversation

ajschmidt8
Copy link
Member

This PR replaces ccache with sccache.

@ajschmidt8 ajschmidt8 added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Jan 31, 2022
@github-actions github-actions bot added the gpuCI label Jan 31, 2022
AyodeAwe
AyodeAwe approved these changes Jan 31, 2022
View reviewed changes
Copy link
Contributor

@AyodeAwe AyodeAwe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ajschmidt8
expose AWS creds to conda builds for sccache
d63132b
@ajschmidt8
show sccache stats after build
ace6cd9
@ajschmidt8
add remaining sccache args to build script
f8289ce
@ajschmidt8
Revert "expose AWS creds to conda builds for sccache"
1ee09d0 
The `conda` recipes are not used in the CI process, so these credentials do not need to be exposed to the `conda` build environment.

This reverts commit d63132b.
@ajschmidt8
add -y flag to install cmd
8f54be3
@ajschmidt8
Copy link
Member Author

rerun tests

@ajschmidt8
Copy link
Member Author

pre-cache build - https://gpuci.gpuopenanalytics.com/job/rapidsai/job/gpuci/job/raft/job/prb/job/raft-prb/1573/

@ajschmidt8
Copy link
Member Author

rerun tests

@ajschmidt8 ajschmidt8 marked this pull request as ready for review February 2, 2022 17:29
@ajschmidt8 ajschmidt8 requested a review from a team as a code owner February 2, 2022 17:29
@ajschmidt8 ajschmidt8 added the 5 - DO NOT MERGE Hold off on merging; see PR for details label Feb 2, 2022
@ajschmidt8
Copy link
Member Author

PR is ready for review, but we'll wait to merge until all the other PRs are confirmed working as well.

@ajschmidt8 ajschmidt8 removed the 5 - DO NOT MERGE Hold off on merging; see PR for details label Feb 3, 2022
@ajschmidt8
Copy link
Member Author

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 7fb0158 into rapidsai:branch-22.04 Feb 3, 2022
@ajschmidt8 ajschmidt8 deleted the sccache branch February 3, 2022 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AyodeAwe AyodeAwe AyodeAwe approved these changes

@raydouglass raydouglass raydouglass approved these changes

Assignees
No one assigned
Labels
gpuCI improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ajschmidt8 @raydouglass @AyodeAwe