Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move random package of cuML to RAFT #449

Merged
merged 8 commits into from
Feb 11, 2022
Merged

Move random package of cuML to RAFT #449

merged 8 commits into from
Feb 11, 2022

Conversation

divyegala
Copy link
Member

This includes:

  • make_arima
  • make_blobs
  • make_regression
  • multi_variable_gaussian
  • permute

@divyegala divyegala requested review from a team as code owners January 19, 2022 01:02
@divyegala divyegala added feature request New feature or request non-breaking Non-breaking change and removed CMake labels Jan 19, 2022
@github-actions github-actions bot added the CMake label Jan 19, 2022
@divyegala divyegala changed the base branch from branch-22.02 to branch-22.04 January 20, 2022 02:10
cjnolet
cjnolet requested changes Jan 24, 2022
View reviewed changes
Copy link
Member

@cjnolet cjnolet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking great so far. Just providing some early feedback. I can review more deeply if you'd like after the cuml side is ready.

cpp/include/raft/random/detail/curand_wrappers.hpp Show resolved Hide resolved
cpp/include/raft/random/detail/make_blobs.cuh Show resolved Hide resolved
@divyegala divyegala requested review from a team as code owners February 10, 2022 22:32
@cjnolet cjnolet removed the request for review from a team February 10, 2022 23:55
@cjnolet
Copy link
Member

cjnolet commented Feb 11, 2022

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 37f627c into rapidsai:branch-22.04 Feb 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjnolet cjnolet cjnolet approved these changes

Assignees
No one assigned
Labels
CMake cpp feature request New feature or request non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@divyegala @cjnolet