Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleaning up cusparse_wrappers #441

Merged
merged 20 commits into from
Feb 8, 2022
Merged

Cleaning up cusparse_wrappers #441

merged 20 commits into from
Feb 8, 2022

Conversation

cjnolet
Copy link
Member

@cjnolet cjnolet commented Jan 12, 2022 •
edited
Loading

Closes #289

@cjnolet cjnolet requested review from a team as code owners January 12, 2022 23:28
@cjnolet cjnolet added the improvement Improvement / enhancement to an existing function label Jan 12, 2022
@github-actions github-actions bot added the cpp label Jan 12, 2022
@cjnolet cjnolet added the non-breaking Non-breaking change label Jan 12, 2022
trivialfis
trivialfis approved these changes Jan 21, 2022
View reviewed changes
Copy link
Member

@trivialfis trivialfis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Always feels good to see code being removed. ;-)

@cjnolet cjnolet changed the base branch from branch-22.02 to branch-22.04 January 25, 2022 15:32
@cjnolet
Copy link
Member Author

cjnolet commented Jan 31, 2022

Functions throwing deprecation warnings in cugraph CI: cusparseCsrmvEx, cusparseCsrmvEx_bufferSize, cusparseDcsr2dense, cusparseScsr2dense

@cjnolet cjnolet added breaking Breaking change and removed non-breaking Non-breaking change labels Feb 1, 2022
ChuckHastings
ChuckHastings approved these changes Feb 1, 2022
View reviewed changes
Copy link
Contributor

@ChuckHastings ChuckHastings left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

!!!!

@cjnolet cjnolet requested a review from a team as a code owner February 4, 2022 19:41
@cjnolet cjnolet removed the request for review from a team February 5, 2022 00:21
seunghwak
seunghwak approved these changes Feb 5, 2022
View reviewed changes
Copy link
Contributor

@seunghwak seunghwak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot!!!!

@cjnolet
Copy link
Member Author

cjnolet commented Feb 8, 2022

rerun tests

@cjnolet
Copy link
Member Author

cjnolet commented Feb 8, 2022

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 29718bd into rapidsai:branch-22.04 Feb 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seunghwak seunghwak seunghwak approved these changes

@ChuckHastings ChuckHastings ChuckHastings approved these changes

@trivialfis trivialfis trivialfis approved these changes

Assignees
No one assigned
Labels
breaking Breaking change cpp improvement Improvement / enhancement to an existing function
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] Update cuSparse deprecated calls
4 participants
@cjnolet @trivialfis @ChuckHastings @seunghwak