Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix comms memory leak #436

Merged
merged 2 commits into from
Jan 3, 2022
Merged

Conversation

seunghwak
Copy link
Contributor

Close #435

  • Add a virtual destructor to comms_iface (to invoke std_comms/mpi_comms destructors when std_comms/mpi_comms objects are deleted through a comms_iface pointer).
  • Set owns_mpi_comms to false in initialize_mpi_comms as this takes an already initialized comm as an input parameter so comm may better be destroyed by the caller (and no need to destroy if comm is MPI_COMM_WORLD, just calling MPI_Finalize will be sufficient).

@seunghwak seunghwak requested review from a team as code owners December 22, 2021 17:30
@github-actions github-actions bot added the cpp label Dec 22, 2021
@seunghwak seunghwak added 3 - Ready for Review bug Something isn't working non-breaking Non-breaking change and removed cpp labels Dec 22, 2021
Copy link
Member

@cjnolet cjnolet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cjnolet
Copy link
Member

cjnolet commented Jan 3, 2022

@gpucibot merge

@rapids-bot rapids-bot bot merged commit c968df4 into rapidsai:branch-22.02 Jan 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 - Ready for Review bug Something isn't working non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Memory leak in comms
3 participants