Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[REVIEW] Disabling fused l2 knn again. Not sure how this got added back. #421

Merged
merged 2 commits into from
Dec 13, 2021
Merged

[REVIEW] Disabling fused l2 knn again. Not sure how this got added back. #421

merged 2 commits into from
Dec 13, 2021

Conversation

cjnolet
Copy link
Member

@cjnolet cjnolet commented Dec 13, 2021

This got added back to raft, somehow. Disabling again until we figure out what's causing the umap gtest failures downstream.

@cjnolet cjnolet requested review from a team as code owners December 13, 2021 18:35
@github-actions github-actions bot added the cpp label Dec 13, 2021
@cjnolet cjnolet added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Dec 13, 2021
divyegala
divyegala approved these changes Dec 13, 2021
View reviewed changes
Copy link
Member

@divyegala divyegala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cjnolet
Copy link
Member Author

cjnolet commented Dec 13, 2021

@gpucibot merge

@rapids-bot rapids-bot bot merged commit a68a4aa into rapidsai:branch-22.02 Dec 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@divyegala divyegala divyegala approved these changes

Assignees
No one assigned
Labels
3 - Ready for Review cpp improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cjnolet @divyegala