Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove IncludeCategories from .clang-format #412

Merged
merged 5 commits into from
Dec 16, 2021
Merged

Remove IncludeCategories from .clang-format #412

merged 5 commits into from
Dec 16, 2021

Conversation

codereport
Copy link
Contributor

It was recently noticed that the IncludeCategories:

IncludeCategories:
  - Regex:           '^<ext/.*\.h>'
    Priority:        2
  - Regex:           '^<.*\.h>'
    Priority:        1
  - Regex:           '^<.*'
    Priority:        2
  - Regex:           '.*'
    Priority:        3

In the .clang-format are not really necessary as ext has no meaning in RAPIDS. This PR removes these.

Note these changes are being made in all repos:

@codereport codereport requested review from a team as code owners December 9, 2021 17:55
@github-actions github-actions bot added the cpp label Dec 9, 2021
@cjnolet cjnolet added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Dec 15, 2021
cjnolet
cjnolet approved these changes Dec 15, 2021
View reviewed changes
Copy link
Member

@cjnolet cjnolet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codereport
Copy link
Contributor Author

Thanks @BradReesWork @cjnolet! I don't have commit access so either of you can feel free to merge : )

@cjnolet
Copy link
Member

cjnolet commented Dec 16, 2021

@gpucibot merge

@rapids-bot rapids-bot bot merged commit d2e5b7a into rapidsai:branch-22.02 Dec 16, 2021
@MatthiasKohl MatthiasKohl mentioned this pull request Dec 17, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BradReesWork BradReesWork BradReesWork approved these changes

@cjnolet cjnolet cjnolet approved these changes

Assignees
No one assigned
Labels
cpp improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@codereport @cjnolet @BradReesWork