Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix nan issues in L2 expanded sqrt KNN distances #411

Merged
merged 1 commit into from
Dec 9, 2021
Merged

fix nan issues in L2 expanded sqrt KNN distances #411

merged 1 commit into from
Dec 9, 2021

Conversation

mdoijade
Copy link
Contributor

@mdoijade mdoijade commented Dec 9, 2021

  • fix nans introduced in l2 expanded sqrt KNN distances due to very small negative 0s produced by fusedL2knn due to floating point computation uncertainty.
  • re-enable fused l2 knn.

@mdoijade
fix nan issues introduced in l2 expanded sqrt distances due to very s…
88f85f9 
…mall negative 0s by fusedL2knn. re-enable fused l2 knn
@mdoijade mdoijade requested review from a team as code owners December 9, 2021 16:19
@github-actions github-actions bot added the cpp label Dec 9, 2021
@cjnolet cjnolet added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Dec 9, 2021
cjnolet
cjnolet approved these changes Dec 9, 2021
View reviewed changes
Copy link
Member

@cjnolet cjnolet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks, Mahesh!

@cjnolet
Copy link
Member

cjnolet commented Dec 9, 2021

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 8ddb61c into rapidsai:branch-22.02 Dec 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjnolet cjnolet cjnolet approved these changes

Assignees
No one assigned
Labels
cpp improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mdoijade @cjnolet