Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LinAlg impl in detail #383

Merged
merged 27 commits into from
Feb 8, 2022
Merged

LinAlg impl in detail #383

merged 27 commits into from
Feb 8, 2022

Conversation

divyegala
Copy link
Member

@divyegala divyegala commented Nov 17, 2021 •
edited by cjnolet
Loading

Addresses #330

@divyegala divyegala added improvement Improvement / enhancement to an existing function breaking Breaking change cpp labels Nov 17, 2021
@divyegala divyegala requested review from a team as code owners November 17, 2021 02:00
ajschmidt8
ajschmidt8 approved these changes Nov 17, 2021
View reviewed changes
Copy link
Member

@ajschmidt8 ajschmidt8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving ops-codeowner file changes

@divyegala divyegala changed the title LinAlg and sparse LinAlg impl in detail LinAlg impl in detail Nov 17, 2021
@cjnolet cjnolet mentioned this pull request Dec 7, 2021
Closed
cjnolet
cjnolet requested changes Dec 15, 2021
View reviewed changes
Copy link
Member

@cjnolet cjnolet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've only gone through it quickly in a first pass so far but changes look great for the most part. Just saw a couple smaller things initially.

cpp/include/raft/distance/detail/distance.cuh Outdated Show resolved Hide resolved
cpp/include/raft/handle.hpp Outdated Show resolved Hide resolved
cpp/include/raft/linalg/binary_op.hpp Show resolved Hide resolved
cpp/include/raft/linalg/eig.hpp Outdated Show resolved Hide resolved
@divyegala divyegala changed the base branch from branch-22.02 to branch-22.04 January 25, 2022 17:09
cjnolet
cjnolet requested changes Jan 26, 2022
View reviewed changes
Copy link
Member

@cjnolet cjnolet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delayed in the review- this is a massive set of changes to go through. Mostly small things at this point. This is almost ready to go. Will look through cuml side next.

cpp/include/raft/distance/distance_type.hpp Show resolved Hide resolved
cpp/include/raft/linalg/detail/eig.hpp Show resolved Hide resolved
cpp/include/raft/linalg/detail/lanczos.hpp Outdated Show resolved Hide resolved
cjnolet
cjnolet previously approved these changes Jan 27, 2022
View reviewed changes
@cjnolet cjnolet mentioned this pull request Jan 30, 2022
Closed
@divyegala divyegala requested a review from a team as a code owner February 2, 2022 21:12
@cjnolet cjnolet removed the request for review from a team February 2, 2022 23:20
@cjnolet cjnolet dismissed their stale review February 7, 2022 20:11

Using new raft codeowners role

cjnolet
cjnolet approved these changes Feb 7, 2022
View reviewed changes
Copy link
Member

@cjnolet cjnolet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cjnolet
Copy link
Member

cjnolet commented Feb 8, 2022

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 66a60b9 into rapidsai:branch-22.04 Feb 8, 2022
rapids-bot bot pushed a commit to rapidsai/cuml that referenced this pull request Feb 8, 2022
@divyegala
Updating RAFT linalg headers (#4515)
f95e93b 
Depends on rapidsai/raft#383

Authors:
  - Divye Gala (https://github.com/divyegala)
  - Corey J. Nolet (https://github.com/cjnolet)

Approvers:
  - Corey J. Nolet (https://github.com/cjnolet)

URL: #4515
vimarsh6739 pushed a commit to vimarsh6739/cuml that referenced this pull request Oct 9, 2023
@divyegala
Updating RAFT linalg headers (rapidsai#4515)
94166bc 
Depends on rapidsai/raft#383

Authors:
  - Divye Gala (https://github.com/divyegala)
  - Corey J. Nolet (https://github.com/cjnolet)

Approvers:
  - Corey J. Nolet (https://github.com/cjnolet)

URL: rapidsai#4515
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ajschmidt8 ajschmidt8 ajschmidt8 approved these changes

@cjnolet cjnolet cjnolet approved these changes

Assignees
No one assigned
Labels
breaking Breaking change cpp improvement Improvement / enhancement to an existing function
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@divyegala @cjnolet @ajschmidt8