Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix wrong lda parameter in gemv #327

Merged
merged 4 commits into from
Sep 16, 2021
Merged

Fix wrong lda parameter in gemv #327

merged 4 commits into from
Sep 16, 2021

Conversation

achirkin
Copy link
Contributor

@achirkin achirkin commented Sep 14, 2021 •
edited
Loading

Fix wrong lda parameter in raft::linalg::gemv. lda should always be along n_rows direction, independently of trans_a. I also took a liberty to add couple more overloads and documentation.

@achirkin achirkin requested review from a team as code owners September 14, 2021 09:02
@achirkin achirkin added bug Something isn't working non-breaking Non-breaking change 3 - Ready for Review and removed cpp CMake labels Sep 14, 2021
@achirkin achirkin self-assigned this Sep 14, 2021
@achirkin achirkin mentioned this pull request Sep 15, 2021
Merged
cjnolet
cjnolet requested changes Sep 15, 2021
View reviewed changes
Copy link
Member

@cjnolet cjnolet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes and tests look great. Just one minor detail in the tests

cpp/test/linalg/gemv.cu Outdated Show resolved Hide resolved
@achirkin achirkin requested a review from cjnolet September 16, 2021 07:25
@achirkin achirkin changed the title [REVIEW] Fix wrong lda parameter in gemv Fix wrong lda parameter in gemv Sep 16, 2021
cjnolet
cjnolet approved these changes Sep 16, 2021
View reviewed changes
Copy link
Member

@cjnolet cjnolet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @achirkin!

@cjnolet
Copy link
Member

cjnolet commented Sep 16, 2021

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 0286095 into rapidsai:branch-21.10 Sep 16, 2021
@achirkin achirkin deleted the fix-gemv-wrong-lda branch March 31, 2022 06:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChuckHastings ChuckHastings ChuckHastings approved these changes

@BradReesWork BradReesWork BradReesWork approved these changes

@cjnolet cjnolet cjnolet approved these changes

Assignees

@achirkin achirkin

Labels
3 - Ready for Review bug Something isn't working CMake cpp non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@achirkin @cjnolet @BradReesWork @ChuckHastings