-
Notifications
You must be signed in to change notification settings - Fork 197
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[REVIEW] Overlap epilog compute with ldg of next grid stride in pairwise distance & fusedL2NN kernels #292
Merged
rapids-bot
merged 45 commits into
rapidsai:branch-21.08
from
mdoijade:overlapComputeLdgGridStride
Jul 15, 2021
Merged
[REVIEW] Overlap epilog compute with ldg of next grid stride in pairwise distance & fusedL2NN kernels #292
rapids-bot
merged 45 commits into
rapidsai:branch-21.08
from
mdoijade:overlapComputeLdgGridStride
Jul 15, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r usage in all contraction based kernels so that n is along x dir and m is along y dir blocks
…kernels. --add launch config generator function to launch optimal grid size kernel for these pairwise dist kernels
…ed up over previous version. -- improve logic of the grid launch config generator for x-dir blocks
…ced val for pre-volta arch
… for subsequent gridStrideX variations. this overall improves perf of fusedL2NN to 1.85x over previous version. --Also remove checking keys only check values in fusedL2nn test case, as it may happen a row has multiple keys with same min val
…und in launchConfigGenerator. --Use constexpr in shmemSize.
…e sure next grid stride doesn't pollute shmem before completion of this calculation
…t iteration of grid stride
…of hellinger formula
…pected to work on pdf
…and reverting in post completion. also add unrolls to ldg arrays in contractions
…improvement for pairwise distance kernels and fusedL2NN kernel
@teju85 for help with review. |
dantegd
added
improvement
Improvement / enhancement to an existing function
non-breaking
Non-breaking change
labels
Jul 13, 2021
teju85
approved these changes
Jul 14, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes LGTM.
@gpucibot merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
overlap epilog compute with ldg of next grid stride in pairwise distance base class.
gives 2-3% perf improvement for pairwise distance kernels and fusedL2NN kernel.