Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

One cudaStream_t instance per raft::handle_t #291

Merged
merged 58 commits into from
Dec 13, 2021
Merged

One cudaStream_t instance per raft::handle_t #291

merged 58 commits into from
Dec 13, 2021

Conversation

divyegala
Copy link
Member

@divyegala divyegala commented Jul 12, 2021 •
edited
Loading

closes #293
closes #115

This PR also updates the cython build to std=c++17.

@divyegala divyegala requested review from a team as code owners July 12, 2021 21:49
@divyegala divyegala marked this pull request as draft July 12, 2021 21:49
@divyegala divyegala added breaking Breaking change improvement Improvement / enhancement to an existing function labels Jul 14, 2021
@divyegala divyegala marked this pull request as ready for review July 14, 2021 20:52
@divyegala
Copy link
Member Author

Depends on rapidsai/rmm#818

@dantegd dantegd requested review from wphicks and cjnolet July 14, 2021 21:40
seunghwak
seunghwak reviewed Jul 15, 2021
View reviewed changes
cpp/include/raft/handle.hpp Outdated Show resolved Hide resolved
cpp/include/raft/handle.hpp Outdated Show resolved Hide resolved
cpp/include/raft/handle.hpp Outdated Show resolved Hide resolved
wphicks
wphicks approved these changes Jul 15, 2021
View reviewed changes
cpp/test/handle.cpp Outdated Show resolved Hide resolved
@divyegala divyegala requested a review from seunghwak July 16, 2021 17:22
@divyegala
Copy link
Member Author

@cjnolet whenever you get a chance to review, now that internal streams don't exist as a vector anymore, the brute force KNN detail API had to be updated accordingly. I think it will look cleaner if that API also just accepted the handle instead. If you agree, I'll go ahead and change that API

cjnolet
cjnolet requested changes Jul 16, 2021
View reviewed changes
Copy link
Member

@cjnolet cjnolet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, just mostly a question about the use of default_stream

cpp/test/linalg/cholesky_r1.cu Show resolved Hide resolved
python/raft/common/handle.pyx Show resolved Hide resolved
python/raft/common/handle.pyx Outdated Show resolved Hide resolved
cpp/include/raft/handle.hpp Outdated Show resolved Hide resolved
@github-actions github-actions bot removed the gpuCI label Nov 17, 2021
divyegala and others added 21 commits November 17, 2021 13:51
@divyegala
correcting legacy to per-thread
480ba37
@divyegala
Merge remote-tracking branch 'upstream/branch-21.12' into imp-21.10-h…
1877061 
…andle_stream
@divyegala
Merge remote-tracking branch 'upstream/branch-22.02' into imp-21.10-h…
1be9fc7 
…andle_stream
@divyegala
Merge remote-tracking branch 'upstream/branch-21.12' into imp-21.10-h…
0efbd91 
…andle_stream
@divyegala
Merge remote-tracking branch 'upstream/branch-22.02' into imp-21.10-h…
ceac531 
…andle_stream
@divyegala
merging upstream
239a887
@divyegala
merging upstream
41d0694
@divyegala
Merge remote-tracking branch 'upstream/branch-22.02' into imp-21.10-h…
a89ab29 
…andle_stream
@divyegala
fixing compiler error
d106d6e
@divyegala
merging upstream
daadd95
@cjnolet
Reverting fused l2 changes. cuml CI still seems to be broken
7051e39
@cjnolet
Fixing style
6bb7eeb
@divyegala
merging corey's fused l2 knn bug revert
3322ebe
@divyegala
fixing macro name
cbb0540
@divyegala
fixing typo with curly brace
ea97177
@divyegala
Merge remote-tracking branch 'upstream/branch-22.02' into imp-21.10-h…
8338dcc 
…andle_stream
@cjnolet
Adding no throw macro variants
9659249
@cjnolet
Fixing typo
d12db1c
@divyegala
pulling corey's macro updates
6186ead
@divyegala
merging upstream
5ed4289
@divyegala
merging upstream
e97a938
@divyegala
Copy link
Member Author

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 906e5e6 into rapidsai:branch-22.02 Dec 13, 2021
rapids-bot bot pushed a commit to rapidsai/cugraph that referenced this pull request Dec 14, 2021
@divyegala
Raft Handle Updates to cuGraph (#1894)
7197258 
Depends on rapidsai/raft#291

Authors:
  - Divye Gala (https://github.com/divyegala)

Approvers:
  - Brad Rees (https://github.com/BradReesWork)
  - AJ Schmidt (https://github.com/ajschmidt8)
  - Rick Ratzel (https://github.com/rlratzel)
  - Chuck Hastings (https://github.com/ChuckHastings)

URL: #1894
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ajschmidt8 ajschmidt8 ajschmidt8 approved these changes

@tfeher tfeher tfeher approved these changes

@wphicks wphicks Awaiting requested review from wphicks

@seunghwak seunghwak Awaiting requested review from seunghwak

@ChuckHastings ChuckHastings Awaiting requested review from ChuckHastings

@cjnolet cjnolet Awaiting requested review from cjnolet

Assignees
No one assigned
Labels
breaking Breaking change CMake cpp improvement Improvement / enhancement to an existing function python
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEA] Update raft::handle_t to be coupled with one cudaStream_t instance [FEA] upgrade CUDA stream pool
7 participants
@divyegala @cjnolet @tfeher @ajschmidt8 @wphicks @ChuckHastings @seunghwak