Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIX] Always add faiss library alias if it's missing #287

Merged
merged 3 commits into from
Jul 9, 2021
Merged

[FIX] Always add faiss library alias if it's missing #287

merged 3 commits into from
Jul 9, 2021

Conversation

trxcllnt
Copy link
Collaborator

@trxcllnt trxcllnt commented Jul 7, 2021

Always add the FAISS::FAISS library target alias if it doesn't exist. This can happen if cuML is built and installs FAISS before cuGraph or vice-versa.

Related PRs:
rapidsai/cuml#4028
rapidsai/cugraph#1694

Note: We can probably remove the get_faiss.cmake file in cuML and cuGraph since they both should get it from RAFT.

@cjnolet cjnolet added 3 - Ready for Review improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Jul 7, 2021
cjnolet
cjnolet approved these changes Jul 7, 2021
View reviewed changes
Copy link
Member

@cjnolet cjnolet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@trxcllnt
Copy link
Collaborator Author

trxcllnt commented Jul 8, 2021

rerun tests

@trxcllnt trxcllnt requested review from a team as code owners July 9, 2021 01:27
@trxcllnt
Copy link
Collaborator Author

trxcllnt commented Jul 9, 2021

rerun tests

@trxcllnt trxcllnt mentioned this pull request Jul 9, 2021
Closed
@dantegd
Copy link
Member

dantegd commented Jul 9, 2021

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 22a16dd into rapidsai:branch-21.08 Jul 9, 2021
@wphicks wphicks mentioned this pull request Jul 12, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjnolet cjnolet cjnolet approved these changes

@dantegd dantegd dantegd approved these changes

Assignees
No one assigned
Labels
3 - Ready for Review CMake cpp improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@trxcllnt @dantegd @cjnolet