expose epsilon parameter to allow precision to to be specified #275
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChuckHastings
added
3 - Ready for Review
breaking
seunghwak
approved these changes
Jun 15, 2021
| const float epsilon{1e-6}; | ||
| return ((w > -epsilon) && (w < epsilon)); | ||
| bool __device__ near_zero<int32_t>(int32_t w, int32_t epsilon) { | ||
| return (w == 0); |
There was a problem hiding this comment.
Why aren't we using epsilon here?
There was a problem hiding this comment.
For integer weights we can do an exact comparison to zero. For floating point values we need to do an approximate comparison.
|
@gpucibot merge |
rapids-bot bot
pushed a commit
to rapidsai/cugraph
that referenced
this pull request
Jun 16, 2021
Closes #1645 Closes #1646 Expose the precision parameter (epsilon in the Date/Nagi implementation) of the Hungarian algorithm to be controllable by the user. Add support for rectangular matrices. Will be enabled for CI after rapidsai/raft#275 is merged. Authors: - Chuck Hastings (https://github.com/ChuckHastings) Approvers: - Andrei Schaffer (https://github.com/aschaffer) - Brad Rees (https://github.com/BradReesWork) - Kumar Aatish (https://github.com/kaatish) URL: #1673
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per user request, this PR exposes the epsilon value that controls the precision where the Hungarian algorithm determines that a value has been reduced to sufficiently close to 0.