Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[REVIEW] Move FAISS ANN wrappers to RAFT #265

Merged
merged 18 commits into from
Jun 9, 2021
Merged

[REVIEW] Move FAISS ANN wrappers to RAFT #265

merged 18 commits into from
Jun 9, 2021

Conversation

cjnolet
Copy link
Member

@cjnolet cjnolet commented Jun 8, 2021

No description provided.

@cjnolet cjnolet requested review from a team as code owners June 8, 2021 21:50
@github-actions github-actions bot added the cpp label Jun 8, 2021
@cjnolet cjnolet added feature request New feature or request non-breaking Non-breaking change labels Jun 8, 2021
@cjnolet cjnolet mentioned this pull request Jun 8, 2021
Merged
viclafargue
viclafargue approved these changes Jun 9, 2021
View reviewed changes
Copy link
Contributor

@viclafargue viclafargue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this. I'm sure the cuGraph team or others might be interested in using it! Just one comment/question. Otherwise, it looks good to me!

cpp/include/raft/spatial/knn/detail/ivf_pq_ann.cuh Outdated Show resolved Hide resolved
dantegd
dantegd approved these changes Jun 9, 2021
View reviewed changes
Copy link
Member

@dantegd dantegd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm except it's missing an update for the header name change:

In file included from ../test/sparse/knn.cu:22:
../include/raft/sparse/selection/knn.cuh:36:10: fatal error: raft/spatial/knn/detail/brute_force_knn.cuh: No such file or directory
   36 | #include <raft/spatial/knn/detail/brute_force_knn.cuh>
      |

@cjnolet
Copy link
Member Author

cjnolet commented Jun 9, 2021

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 1c1b4a0 into rapidsai:branch-21.08 Jun 9, 2021
rapids-bot bot pushed a commit to rapidsai/cuml that referenced this pull request Jun 16, 2021
@cjnolet
Moving FAISS ANN wrapper to raft (#3963)
1be5e3a 
This accompanies the RAFT PR: rapidsai/raft#265

Closes #3954

Authors:
  - Corey J. Nolet (https://github.com/cjnolet)

Approvers:
  - Victor Lafargue (https://github.com/viclafargue)
  - Dante Gama Dessavre (https://github.com/dantegd)

URL: #3963
vimarsh6739 pushed a commit to vimarsh6739/cuml that referenced this pull request Oct 9, 2023
@cjnolet
Moving FAISS ANN wrapper to raft (rapidsai#3963)
4925cde 
This accompanies the RAFT PR: rapidsai/raft#265

Closes rapidsai#3954

Authors:
  - Corey J. Nolet (https://github.com/cjnolet)

Approvers:
  - Victor Lafargue (https://github.com/viclafargue)
  - Dante Gama Dessavre (https://github.com/dantegd)

URL: rapidsai#3963
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@viclafargue viclafargue viclafargue approved these changes

@BradReesWork BradReesWork BradReesWork approved these changes

@dantegd dantegd dantegd approved these changes

Assignees
No one assigned
Labels
cpp feature request New feature or request non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@cjnolet @dantegd @viclafargue @BradReesWork