Fix mst knn test build failure due to RMM device_buffer change #253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dantegd @divyegala can you please help with review & merge? |
|
@teju85 for visibility. |
ajschmidt8
reviewed
Jun 7, 2021
ci/gpu/build.sh
Outdated
| @@ -51,7 +51,7 @@ gpuci_conda_retry install -c conda-forge -c rapidsai -c rapidsai-nightly -c nvid | |||
| "rmm=${MINOR_VERSION}" \ | |||
| "dask-cudf=${MINOR_VERSION}" \ | |||
| "dask-cuda=${MINOR_VERSION}" \ | |||
| "ucx-py=${MINOR_VERSION}" \ | |||
| "ucx-py=0.21" \ | |||
There was a problem hiding this comment.
This change is available in fedab76. Please merge the latest changes from branch-21.08 into your PR.
harrism
reviewed
Jun 7, 2021
| mst_input.csr_h.weights.size() * sizeof(weight_t)); | ||
| csr_d.offsets = rmm::device_buffer( | ||
| mst_input.csr_h.offsets.data(), | ||
| mst_input.csr_h.offsets.size() * sizeof(edge_t), handle.get_stream()); |
There was a problem hiding this comment.
Looks like this was a needed change anyway -- default stream is probably not what you wanted here?
There was a problem hiding this comment.
hmm that sounds right, but maybe such runtime failure wasn't getting triggered yet.
dantegd
approved these changes
Jun 8, 2021
|
@gpucibot merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This RMM change has caused below build failure - rapidsai/rmm@7cbcd97
[ 22%] Building CUDA object CMakeFiles/test_raft.dir/test/sparse/symmetrize.cu.o
/data/raft/cpp/test/mst.cu(202): error: no instance of constructor "rmm::device_buffer::device_buffer" matches the argument list
argument types are: (int *, unsigned long)
detected during instantiation of "void raft::mst::MSTTest<vertex_t, edge_t, weight_t>::SetUp() [with vertex_t=int, edge_t=int, weight_t=float]"
/data/raft/cpp/test/mst.cu(205): error: no instance of constructor "rmm::device_buffer::device_buffer" matches the argument list
argument types are: (int *, unsigned long)
detected during instantiation of "void raft::mst::MSTTest<vertex_t, edge_t, weight_t>::SetUp() [with vertex_t=int, edge_t=int, weight_t=float]"
/data/raft/cpp/test/mst.cu(208): error: no instance of constructor "rmm::device_buffer::device_buffer" matches the argument list
argument types are: (float *, unsigned long)
detected during instantiation of "void raft::mst::MSTTest<vertex_t, edge_t, weight_t>::SetUp() [with vertex_t=int, edge_t=int, weight_t=float]"
3 errors detected in the compilation of "/data/raft/cpp/test/mst.cu".
make[2]: *** [CMakeFiles/test_raft.dir/build.make:594: CMakeFiles/test_raft.dir/test/mst.cu.o] Error 1
make[2]: *** Waiting for unfinished jobs....
make[1]: *** [CMakeFiles/Makefile2:137: CMakeFiles/test_raft.dir/all] Error 2
make: *** [Makefile:136: all] Error 2