Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make package installations in CI stricter #2467

Merged
merged 6 commits into from
Oct 11, 2024

Conversation

jameslamb
Copy link
Member

Description

Contributes to rapidsai/build-planning#106

Proposes specifying the RAPIDS version in conda install calls in CI that install CI artifacts, to reduce the risk of CI jobs picking up artifacts from other releases.

Also proposes combining together successive pip install calls. pip install AB is safer than pip install A; pip install B because pip doesn't take the current set of installed packages into consideration when it installs new packages.

@jameslamb jameslamb added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change 2 - In Progress Currenty a work in progress labels Oct 8, 2024
@github-actions github-actions bot added the ci label Oct 8, 2024
@jameslamb jameslamb changed the title WIP: make package installations in CI stricter make package installations in CI stricter Oct 9, 2024
@jameslamb jameslamb marked this pull request as ready for review October 9, 2024 14:09
@jameslamb jameslamb requested a review from a team as a code owner October 9, 2024 14:09
ci/build_docs.sh Outdated Show resolved Hide resolved
ci/build_docs.sh Show resolved Hide resolved
@jameslamb jameslamb removed the 2 - In Progress Currenty a work in progress label Oct 9, 2024
@jameslamb
Copy link
Member Author

/merge

@rapids-bot rapids-bot bot merged commit 907edb8 into rapidsai:branch-24.12 Oct 11, 2024
70 checks passed
@jameslamb jameslamb deleted the ci-conda-installs branch October 11, 2024 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants