Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Python 3.12 #2428

Merged
merged 2 commits into from
Sep 9, 2024
Merged

Conversation

jameslamb
Copy link
Member

Description

Contributes to rapidsai/build-planning#40

This PR adds support for Python 3.12.

Notes for Reviewers

This is part of ongoing work to add Python 3.12 support across RAPIDS.
It temporarily introduces a build/test matrix including Python 3.12, from rapidsai/shared-workflows#213.

A follow-up PR will revert back to pointing at the branch-24.10 branch of shared-workflows once all
RAPIDS repos have added Python 3.12 support.

This will fail until all dependencies have been updates to Python 3.12

CI here is expected to fail until all of this project's upstream dependencies support Python 3.12.

This can be merged whenever all CI jobs are passing.

@jameslamb jameslamb added non-breaking Non-breaking change improvement Improvement / enhancement to an existing function labels Sep 4, 2024
@github-actions github-actions bot added the python label Sep 4, 2024
@jameslamb jameslamb changed the title Add support for Python 3.12 WIP: Add support for Python 3.12 Sep 4, 2024
@bdice
Copy link
Contributor

bdice commented Sep 9, 2024

I noticed a conda failure here that looks like a network error. I have drafted a PR that adds DependencyNeedsBuildingError to our list of supported cases for "network failure; retry" in gha-tools. rapidsai/gha-tools#115

Copy link
Contributor

@bdice bdice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this will be good to go once CI passes. There is just one C++ test still running, but it's unaffected by this PR's changes.

@jameslamb jameslamb changed the title WIP: Add support for Python 3.12 Add support for Python 3.12 Sep 9, 2024
@jameslamb jameslamb marked this pull request as ready for review September 9, 2024 18:39
@jameslamb jameslamb requested review from a team as code owners September 9, 2024 18:39
@jameslamb jameslamb requested a review from msarahan September 9, 2024 18:39
@jameslamb
Copy link
Member Author

You're too fast for me @bdice ! I was just about to ask you to review this 😂

Thank you, yeah I agree.

@jameslamb
Copy link
Member Author

/merge

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Improvement / enhancement to an existing function non-breaking Non-breaking change python
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants