Use dynamic version for raft-ann-bench #2285
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KyleFromNVIDIA
added
improvement
cjnolet
approved these changes
May 1, 2024
bdice
approved these changes
May 1, 2024
|
/merge |
jiangyinzuo
added a commit
to jiangyinzuo/raft
that referenced
this pull request
May 3, 2024
rapidsai#2285 forgets to include `VERSION` file, causing _version.py not find `VERSION` file.
KyleFromNVIDIA
added a commit
to KyleFromNVIDIA/raft
that referenced
this pull request
May 8, 2024
rapidsai#2285 added dynamic versioning to pyproject.toml for raft-ann-bench, but did not properly copy in the VERSION file. Copy it in with tool.setuptools.package-data.
rapids-bot bot
pushed a commit
that referenced
this pull request
May 9, 2024
#2285 added dynamic versioning to `pyproject.toml` for `raft-ann-bench`, but did not properly copy in the `VERSION` file. Copy it in with `tool.setuptools.package-data`. Authors: - Kyle Edwards (https://github.com/KyleFromNVIDIA) Approvers: - Divye Gala (https://github.com/divyegala) - Bradley Dice (https://github.com/bdice) URL: #2299
abc99lr
pushed a commit
to abc99lr/raft
that referenced
this pull request
May 10, 2024
rapidsai#2285 added dynamic versioning to `pyproject.toml` for `raft-ann-bench`, but did not properly copy in the `VERSION` file. Copy it in with `tool.setuptools.package-data`. Authors: - Kyle Edwards (https://github.com/KyleFromNVIDIA) Approvers: - Divye Gala (https://github.com/divyegala) - Bradley Dice (https://github.com/bdice) URL: rapidsai#2299
AyodeAwe
added a commit
to AyodeAwe/raft
that referenced
this pull request
May 20, 2024
AyodeAwe
added a commit
that referenced
this pull request
May 20, 2024
* add missing files to update-version.sh * use alternate regex * remove unneeded sed following #2285
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributes to rapidsai/build-planning#15.