Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

define 'ucx' pytest marker #2281

Merged
merged 3 commits into from
May 3, 2024
Merged

define 'ucx' pytest marker #2281

merged 3 commits into from
May 3, 2024

Conversation

jameslamb
Copy link
Member

Looking through logs on #2279, I noticed this warning:

test/test_comms.py:267
  /__w/raft/raft/python/raft-dask/raft_dask/test/test_comms.py:267: PytestUnknownMarkWarning: Unknown pytest.mark.ucx - is this a typo?  You can register custom marks to avoid this warning - for details, see https://docs.pytest.org/en/stable/how-to/mark.html
    @pytest.mark.ucx

(build link)

This resolves it.

How I tested this

Looked for all such cases like this:

git grep -E 'mark.*ucx'

Hopefully we'll see this log disappear from the conda-python-tests CI logs on this PR.

@jameslamb jameslamb added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Apr 26, 2024
@jameslamb jameslamb requested a review from a team as a code owner April 26, 2024 20:09
@jameslamb jameslamb mentioned this pull request Apr 29, 2024
Closed
@jameslamb jameslamb requested a review from a team as a code owner April 29, 2024 15:07
@github-actions github-actions bot added the ci label Apr 29, 2024
@github-actions github-actions bot removed the ci label Apr 29, 2024
@jameslamb jameslamb added 4 - Waiting on Reviewer Waiting for reviewer to review or respond 3 - Ready for Review and removed 4 - Waiting on Reviewer Waiting for reviewer to review or respond labels May 1, 2024
@mroeschke mroeschke mentioned this pull request May 2, 2024
Merged
@dantegd
Copy link
Member

dantegd commented May 3, 2024

/merge

@rapids-bot rapids-bot bot merged commit da3b9a9 into rapidsai:branch-24.06 May 3, 2024
69 checks passed
@jameslamb jameslamb deleted the fix/pytest-marker branch May 3, 2024 20:16
rapids-bot bot pushed a commit that referenced this pull request May 8, 2024
@mroeschke
Enable warnings as errors for Python tests (#2288)
4c1bf03 
As part of rapidsai/build-planning#26, warnings in Python tests will be converted to test failures


`ignore:Unknown pytest.mark.ucx:PytestUnknownMarkWarning` could be removed once #2281 is merged cc @jameslamb

Authors:
  - Matthew Roeschke (https://github.com/mroeschke)

Approvers:
  - Dante Gama Dessavre (https://github.com/dantegd)

URL: #2288
abc99lr pushed a commit to abc99lr/raft that referenced this pull request May 10, 2024
@mroeschke @abc99lr
Enable warnings as errors for Python tests (rapidsai#2288)
5dfb555 
As part of rapidsai/build-planning#26, warnings in Python tests will be converted to test failures


`ignore:Unknown pytest.mark.ucx:PytestUnknownMarkWarning` could be removed once rapidsai#2281 is merged cc @jameslamb

Authors:
  - Matthew Roeschke (https://github.com/mroeschke)

Approvers:
  - Dante Gama Dessavre (https://github.com/dantegd)

URL: rapidsai#2288
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bdice bdice bdice approved these changes

@raydouglass raydouglass raydouglass approved these changes

@dantegd dantegd dantegd approved these changes

Assignees
No one assigned
Labels
3 - Ready for Review improvement Improvement / enhancement to an existing function non-breaking Non-breaking change python
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jameslamb @dantegd @raydouglass @bdice