Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add CAGRA-Q subspace dim = 4 support #2244

Merged
merged 8 commits into from
Apr 3, 2024
Merged

Add CAGRA-Q subspace dim = 4 support #2244

merged 8 commits into from
Apr 3, 2024
+21 −17

Conversation

enp1s0
Copy link
Member

@enp1s0 enp1s0 commented Mar 25, 2024 •
edited
Loading

This PR adds the support for subspace dim (pq_dim) = 4 in CAGRA-Q

@enp1s0 enp1s0 requested a review from a team as a code owner March 25, 2024 12:54
@enp1s0 enp1s0 self-assigned this Mar 25, 2024
@github-actions github-actions bot added the cpp label Mar 25, 2024
@enp1s0 enp1s0 added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change and removed cpp labels Mar 25, 2024
@github-actions github-actions bot added the cpp label Mar 25, 2024
achirkin
achirkin approved these changes Apr 2, 2024
View reviewed changes
Copy link
Contributor

@achirkin achirkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@cjnolet
Copy link
Member

cjnolet commented Apr 3, 2024

/merge

@rapids-bot rapids-bot bot merged commit eabe3b0 into rapidsai:branch-24.06 Apr 3, 2024
69 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@achirkin achirkin achirkin approved these changes

@cjnolet cjnolet cjnolet approved these changes

Assignees

@enp1s0 enp1s0

Labels
cpp improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
VS/ML/DM Primitives Release Board
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@enp1s0 @cjnolet @achirkin