Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add CAGRA-Q to ANN benchmarks #2233

Merged
merged 2 commits into from
Mar 21, 2024
Merged

Add CAGRA-Q to ANN benchmarks #2233

merged 2 commits into from
Mar 21, 2024

Conversation

achirkin
Copy link
Contributor

@achirkin achirkin commented Mar 19, 2024 •
edited
Loading

Add the relevant options to the CAGRA parameter parser and refinement to the CAGRA ANN benchmark.
No changes to the library code.

NB: the new option won't work correctly until #2206 is merged.

@achirkin achirkin added feature request New feature or request non-breaking Non-breaking change 2 - In Progress Currenty a work in progress Vector Search Benchmarks labels Mar 19, 2024
@achirkin achirkin self-assigned this Mar 19, 2024
@achirkin achirkin requested a review from a team as a code owner March 19, 2024 18:01
@github-actions github-actions bot added the cpp label Mar 19, 2024
tfeher
tfeher approved these changes Mar 20, 2024
View reviewed changes
Copy link
Contributor

@tfeher tfeher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@achirkin achirkin marked this pull request as draft March 20, 2024 09:06
@achirkin
Copy link
Contributor Author

achirkin commented Mar 20, 2024 •
edited
Loading

Converted this to draft to not merge this by accident while I'm testing the benchmarks on sample dataset

@achirkin achirkin marked this pull request as ready for review March 21, 2024 06:53
@achirkin achirkin added 5 - Ready to Merge and removed 2 - In Progress Currenty a work in progress labels Mar 21, 2024
@achirkin
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit b773494 into rapidsai:branch-24.04 Mar 21, 2024
71 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tfeher tfeher tfeher approved these changes

Assignees

@achirkin achirkin

Labels
5 - Ready to Merge Benchmarks cpp feature request New feature or request non-breaking Non-breaking change Vector Search
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@achirkin @tfeher