Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Loss of Precision in MST weight alteration #223

Merged
merged 6 commits into from
May 27, 2021
Merged

Loss of Precision in MST weight alteration #223

merged 6 commits into from
May 27, 2021

Conversation

divyegala
Copy link
Member

No description provided.

@divyegala divyegala requested review from a team as code owners May 10, 2021 18:36
@github-actions github-actions bot added the cpp label May 10, 2021
@dantegd dantegd added the 2 - In Progress Currenty a work in progress label May 14, 2021
@divyegala divyegala added 3 - Ready for Review bug Something isn't working non-breaking Non-breaking change and removed 2 - In Progress Currenty a work in progress labels May 24, 2021
@divyegala divyegala changed the title [WIP] Loss of Precision in MST weight alteration Loss of Precision in MST weight alteration May 24, 2021
afender
afender requested changes May 24, 2021
View reviewed changes
Copy link
Member

@afender afender left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dynamically selecting 64b only when needed would be a good improvement to consider

cpp/include/raft/sparse/mst/detail/mst_solver_inl.cuh Outdated Show resolved Hide resolved
cpp/include/raft/sparse/hierarchy/detail/mst.cuh Show resolved Hide resolved
@afender afender self-requested a review May 24, 2021 21:27
@afender
Copy link
Member

afender commented May 24, 2021

Thanks @divyegala !

@divyegala
Copy link
Member Author

rerun tests

cjnolet
cjnolet approved these changes May 27, 2021
View reviewed changes
Copy link
Member

@cjnolet cjnolet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cjnolet
Copy link
Member

cjnolet commented May 27, 2021

@gpucibot merge

@rapids-bot rapids-bot bot merged commit c00d3b2 into rapidsai:branch-21.06 May 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@afender afender afender approved these changes

@cjnolet cjnolet cjnolet approved these changes

Assignees
No one assigned
Labels
3 - Ready for Review bug Something isn't working cpp non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@divyegala @afender @cjnolet @dantegd