Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Batch cutlass distance kernels along N matrix dim #2215

Merged
merged 5 commits into from
Mar 14, 2024
Merged

Batch cutlass distance kernels along N matrix dim #2215

merged 5 commits into from
Mar 14, 2024

Conversation

mdoijade
Copy link
Contributor

@mdoijade mdoijade commented Mar 6, 2024

  • batch input matrix with N-dim to at most 65535 to avoid cutlass gridY limitation.

@mdoijade mdoijade requested a review from a team as a code owner March 6, 2024 19:41
@github-actions github-actions bot added the cpp label Mar 6, 2024
@mdoijade mdoijade requested review from cjnolet and tfeher March 7, 2024 07:13
@mdoijade mdoijade added 4 - Waiting on Reviewer Waiting for reviewer to review or respond bug Something isn't working labels Mar 7, 2024
@mdoijade mdoijade self-assigned this Mar 7, 2024
tfeher
tfeher requested changes Mar 8, 2024
View reviewed changes
Copy link
Contributor

@tfeher tfeher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Mahesh for fixing the issue! The PR looks good to me, but could you still add a test?

cpp/include/raft/distance/detail/pairwise_distance_cutlass_base.cuh Show resolved Hide resolved
tfeher
tfeher approved these changes Mar 13, 2024
View reviewed changes
Copy link
Contributor

@tfeher tfeher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Mahesh for the update, LGTM!

@tfeher
Copy link
Contributor

tfeher commented Mar 14, 2024

/merge

@rapids-bot rapids-bot bot merged commit 56c0b3a into rapidsai:branch-24.04 Mar 14, 2024
71 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tfeher tfeher tfeher approved these changes

@cjnolet cjnolet Awaiting requested review from cjnolet

Assignees

@mdoijade mdoijade

Labels
3 - Ready for Review 4 - Waiting on Reviewer Waiting for reviewer to review or respond bug Something isn't working cpp non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mdoijade @tfeher