Fixing workaround for cuSPARSE bug with correct copy dimensions #2185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before merging a fix, we should test whether it actually fixes the bug. |
cjnolet
added
improvement
divyegala
approved these changes
Feb 21, 2024
|
This was tested in cuML with PR: rapidsai/cuml#5777 |
|
/merge |
|
Thanks all! 🙏 |
This was referenced Feb 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR tries to fix the workaround that introduce a temporary copy of the Z matrix for SpMM.
Note that the correct sizing for the copy is crucial - this is covered by the SPARSE_DIST_TEST.
However, I did NOT test whether this fixes the cuSparse bug. CC @cjnolet @trxcllnt