Allow topk larger than 1024 in CAGRA #2181
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reapply changes from rapidsai#2097 This change allows CAGRA search to have an arbitrarily large top-k, instead of being limited to 1024 like in the previous code. This works by using the multi-kernel search path, and replacing the _cuann_find_topk code with the matrix::select_k code - which can handle large K values.
Commit fea490a attempted to fix a problem where the search_params.itopk_size wasn't being set in the CAGRA filter tests. This change was required to enable testing k>1024, since the default itopk_size was too small. However, this broke the unittest for k < 1024 - and was causing illegal memory access errors. Fix by reverting the filter tests to the previous behaviour, and disabling the filter tests for k>1024
benfred
added
improvement
cjnolet
approved these changes
Feb 14, 2024
|
/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reapply changes from #2097
This change allows CAGRA search to have an arbitrarily large top-k, instead of being limited to 1024 like in the previous code.
This works by using the multi-kernel search path, and replacing the _cuann_find_topk code with the matrix::select_k code - which can handle large K values.